Issue with Shrink System

Kamras

Kamras

Member
Whenever I use the shrink command or a shrink potion, if the target is not a BaseCreature the server crashes. Here is the Crash Log . Anyone able to show me how to fix this? I know I need to setup a null check if target is not basecreature, I just have no idea how to do it, least not successfully..

Code: 
System.NullReferenceException: Object reference not set to an instance of an object.
   at Xanthos.ShrinkSystem.ShrinkTarget.OnTarget(Mobile from, Object target)
   at Server.Targeting.Target.Invoke(Mobile from, Object targeted) in k:\Ultima Server\Server\Targeting\Target.cs:line 269
   at Server.Network.PacketHandlers.TargetResponse(NetState state, PacketReader pvSrc) in k:\Ultima Server\Server\Network\PacketHandlers.cs:line 1323
   at Server.Network.MessagePump.HandleReceive(NetState ns) in k:\Ultima Server\Server\Network\MessagePump.cs:line 187
   at Server.Network.MessagePump.Slice() in k:\Ultima Server\Server\Network\MessagePump.cs:line 121
   at Server.Core.Main(String[] args) in k:\Ultima Server\Server\Main.cs:line 577

Here is the ShrinkCommand Script that gets referenced for targets

Code: 
#region AuthorHeader
//
//    Shrink System version 2.0, by Xanthos
//
//
#endregion AuthorHeader
using System;
using Server;
using Server.Items;
using Server.Mobiles;
using Server.Commands;
using Server.Targeting;
using Server.Regions;
using Xanthos.Interfaces;

namespace Xanthos.ShrinkSystem
{
    public class ShrinkCommands
    {
        private static bool m_LockDown; // TODO: need to persist this.

        public static void Initialize()
        {
            CommandHandlers.Register( "Shrink", AccessLevel.Administrator, new CommandEventHandler( Shrink_OnCommand ) );
            CommandHandlers.Register( "ShrinkLockDown", AccessLevel.Administrator, new CommandEventHandler( ShrinkLockDown_OnCommand ) );
            CommandHandlers.Register( "ShrinkRelease", AccessLevel.Administrator, new CommandEventHandler( ShrinkRelease_OnCommand ) );
        }

        public static bool LockDown
        {
            get { return m_LockDown; }
        }

        [Usage( "Shrink" )]
        [Description( "Shrinks a creature." )]
        private static void Shrink_OnCommand( CommandEventArgs e )
        {
            PlayerMobile from = e.Mobile as PlayerMobile;

            if ( null != from )
                from.Target = new ShrinkTarget( from, null, true );
        }

        [Usage( "ShrinkLockDown" )]
        [Description( "Disables all shrinkitems in the world." )]
        private static void ShrinkLockDown_OnCommand( CommandEventArgs e )
        {
            PlayerMobile from = e.Mobile as PlayerMobile;

            if ( null != from )
                SetLockDown( from, true );
        }

        [Usage( "ShrinkRelease" )]
        [Description( "Re-enables all disabled shrink items in the world." )]
        private static void ShrinkRelease_OnCommand( CommandEventArgs e )
        {
            PlayerMobile from = e.Mobile as PlayerMobile;

            if ( null != from )
                SetLockDown( from, false );
        }

        static private void SetLockDown( Mobile from, bool lockDown )
        {
            if ( m_LockDown = lockDown )
            {
                World.Broadcast( 0x35, true, "A server wide shrinkitem lockout has initiated." );
                World.Broadcast( 0x35, true, "All shrunken pets have will remain shruken until further notice." );
            }
            else
            {
                World.Broadcast( 0x35, true, "The server wide shrinkitem lockout has been lifted." );
                World.Broadcast( 0x35, true, "You may once again unshrink shrunken pets." );
            }
        }
    }

    public class ShrinkTarget : Target
    {
        private IShrinkTool m_ShrinkTool;
        private bool m_StaffCommand;

        public ShrinkTarget( Mobile from, IShrinkTool shrinkTool, bool staffCommand ) : base( 10, false, TargetFlags.None )
        {
            m_ShrinkTool = shrinkTool;
            m_StaffCommand = staffCommand;
            from.SendMessage( "Target the pet you wish to shrink." );
        }

        protected override void OnTarget( Mobile from, object target )
        {
            BaseCreature pet = target as BaseCreature;
        
                    
            if ( target == from )
                from.SendMessage( "You cannot shrink yourself!" );
        
            else if ( target is Item )
                from.SendMessage( "You cannot shrink that!" );

            else if ( target is PlayerMobile )
                from.SendMessage( "That person gives you a dirty look!" );
        
            else if ( pet.Mounted == true)
                from.SendMessage( "That person gives you a dirty look!" );

            else if ( Server.Spells.SpellHelper.CheckCombat( from ) )
                from.SendMessage( "You cannot shrink your pet while you are fighting." );

            else if ( null == pet )
                from.SendMessage( "That is not a pet!" );

            else if ( target is BaseHire )
                from.SendMessage( "That person gives you a dirty look!" );

            else if ( pet.IsDeadPet )
                from.SendMessage( "You cannot shrink the dead!" );

            else if ( pet.Summoned )
                from.SendMessage( "You cannot shrink a summoned creature!" );
        
            else if ( pet.Allured )
                from.SendMessage( "You cannot shrink a summoned creature!" );
        
            else if ( target is BaseTalismanSummon )
                from.SendMessage( "You cannot shrink a summoned creature!" );

            else if ( !m_StaffCommand && pet.Combatant != null && pet.InRange( pet.Combatant, 12 ) && pet.Map == pet.Combatant.Map )
                from.SendMessage( "Your pet is fighting; you cannot shrink it yet." );

            else if ( pet.BodyMod != 0 )
                from.SendMessage( "You cannot shrink your pet while it is polymorphed." );

            else if ( !m_StaffCommand && pet.Controlled == false )
                from.SendMessage( "You cannot not shrink wild creatures." );

            else if ( !m_StaffCommand && pet.ControlMaster != from )
                from.SendMessage( "That is not your pet." );

            else if ( !m_StaffCommand && ShrinkItem.IsPackAnimal( pet ) && ( null != pet.Backpack && pet.Backpack.Items.Count > 0 ) )
                from.SendMessage( "You must unload this pet's pack before it can be shrunk." );

            else
            {
                if ( pet.ControlMaster != from && !pet.Controlled )
                {
                    SpawnEntry se = pet.Spawner as SpawnEntry;
                    if ( se != null && se.UnlinkOnTaming )
                    {
                        pet.Spawner.Remove((ISpawnable)pet);
                        pet.Spawner = null;
                    }

                    pet.CurrentWayPoint = null;
                    pet.ControlMaster = from;
                    pet.Controlled = true;
                    pet.ControlTarget = null;
                    pet.ControlOrder = OrderType.Come;
                    pet.Guild = null;
                    pet.Delta( MobileDelta.Noto );
                }

                IEntity p1 = new Entity( Serial.Zero, new Point3D( from.X, from.Y, from.Z ), from.Map );
                IEntity p2 = new Entity( Serial.Zero, new Point3D( from.X, from.Y, from.Z + 50 ), from.Map );

                Effects.SendMovingParticles( p2, p1, ShrinkTable.Lookup( pet ), 1, 0, true, false, 0, 3, 1153, 1, 0, EffectLayer.Head, 0x100 );
                from.PlaySound( 492 );
                from.AddToBackpack( new ShrinkItem( pet ) );

                if ( !m_StaffCommand && null != m_ShrinkTool && m_ShrinkTool.ShrinkCharges > 0 )
                    m_ShrinkTool.ShrinkCharges--;
            }
        }
    }
}
 
Try.. (sorry about the alignment very tired)


Code: 
   	 BaseCreature pet = target as BaseCreature;
	 if (pet == null) 
	     from.SendMessage( "You cannot shrink that!" );
          else if ( target == from )
                from.SendMessage( "You cannot shrink yourself!" );
 
Move this:

Code: 
            else if ( null == pet )
                from.SendMessage( "That is not a pet!" );

so that it is the first "if" condition.

And, really, it should say "pet == null" not "null == pet" - that's just strange.

If you want, you can put it between these 2 lines:

Code: 
            if ( target == from )
                from.SendMessage( "You cannot shrink yourself!" );
      
/// RIGHT HERE --->>>

            else if ( target is Item )
                from.SendMessage( "You cannot shrink that!" );
 
I must be confused and over tired.. but isn't that what I just said? in not so many words :)
 
That worked. I must be tired too.. I way over analyzed that error and tried doing something unnecessary and stupid.. lol thank you :)
 
Lokai, you did look closer though, the placement would be better where you suggested (well almost it would be after Item and PlayerMobile), if the other messages are ever to be shown. I would actually redesign it better myself, to not call the BaseCreature until after the first checks are made (as I like to keep my null checks close and not assign variables unless needed)
[doublepost=1462812001][/doublepost]
Code: 
protected override void OnTarget(Mobile from, object target)
{

  if (target == from)
  from.SendMessage("You cannot shrink yourself!");
  else if (target is Item)
  from.SendMessage("You cannot shrink that!");
  else if (target is PlayerMobile)
  from.SendMessage("That person gives you a dirty look!");
  else if (Server.Spells.SpellHelper.CheckCombat(from))
  from.SendMessage("You cannot shrink your pet while you are fighting.");
  else if (target is BaseHire)
  from.SendMessage("That person gives you a dirty look!");
  else if (target is BaseTalismanSummon)
  from.SendMessage("You cannot shrink a summoned creature!");
  else
  {
  BaseCreature pet = target as BaseCreature;

  if (pet == null)
  {
  from.SendMessage("That is not a pet!");
  }
  else
  {
  if (pet.Mounted == true)
  from.SendMessage("That person gives you a dirty look!");

  else if (pet.IsDeadPet)
  from.SendMessage("You cannot shrink the dead!");

  else if (pet.Summoned)
  from.SendMessage("You cannot shrink a summoned creature!");

  else if (pet.Allured)
  from.SendMessage("You cannot shrink a summoned creature!");

  else if (!m_StaffCommand && pet.Combatant != null && pet.InRange(pet.Combatant, 12) && pet.Map == pet.Combatant.Map)
  from.SendMessage("Your pet is fighting; you cannot shrink it yet.");

  else if (pet.BodyMod != 0)
  from.SendMessage("You cannot shrink your pet while it is polymorphed.");

  else if (!m_StaffCommand && pet.Controlled == false)
  from.SendMessage("You cannot not shrink wild creatures.");

  else if (!m_StaffCommand && pet.ControlMaster != from)
  from.SendMessage("That is not your pet.");

  else if (!m_StaffCommand && ShrinkItem.IsPackAnimal(pet) && (null != pet.Backpack && pet.Backpack.Items.Count > 0))
  from.SendMessage("You must unload this pet's pack before it can be shrunk.");

  else
  {
  if (pet.ControlMaster != from && !pet.Controlled)
  {
  SpawnEntry se = pet.Spawner as SpawnEntry;
  if (se != null && se.UnlinkOnTaming)
  {
  pet.Spawner.Remove((ISpawnable)pet);
  pet.Spawner = null;
  }

  pet.CurrentWayPoint = null;
  pet.ControlMaster = from;
  pet.Controlled = true;
  pet.ControlTarget = null;
  pet.ControlOrder = OrderType.Come;
  pet.Guild = null;
  pet.Delta(MobileDelta.Noto);
  }

  IEntity p1 = new Entity(Serial.Zero, new Point3D(from.X, from.Y, from.Z), from.Map);
  IEntity p2 = new Entity(Serial.Zero, new Point3D(from.X, from.Y, from.Z + 50), from.Map);

  Effects.SendMovingParticles(p2, p1, ShrinkTable.Lookup(pet), 1, 0, true, false, 0, 3, 1153, 1, 0, EffectLayer.Head, 0x100);
  from.PlaySound(492);
  from.AddToBackpack(new ShrinkItem(pet));

  if (!m_StaffCommand && null != m_ShrinkTool && m_ShrinkTool.ShrinkCharges > 0)
  m_ShrinkTool.ShrinkCharges--;
  }
  }
  }
}
[doublepost=1462812051][/doublepost]I don't know.. I keep getting double post merged and my alignment gets lost.. Good Night! :)
 
Last edited:
You must log in or register to reply here.

Active Shards

Donations

Total amount
$0.00
Goal
$1,000.00
View
Back