BaseCreature DoHarmful commented out

[Hjornskar]

Line 4259 of BaseCreature, DoHarmful has been commented out. Looking at the repo history, I see this change was made on July 29, but the reasoning is not clear and it wasn't mentioned in the commit notes.

One side effect is that a player can command a pet to attack another player's pet while both players and both pets remain blue. This seems like odd behavior. Uncommenting DoHarmful and repeating the same scenario results in the aggressive player being guard whacked, which seems like the appropriate result.

Can anyone explain why this section was commented out originally?

 

[Dexter_Lexia]

The base method is still called. This was to prevent a pets owner from being placed in the pets combatants aggro list.

 

[Hjornskar]

Thank you for the explanation.

It may still be problematic for pets in town in Felucca. Running a test shard, I was able to use my pet to attack another player's pet and both my character and pet remained blue. Can't speak to what happens on EA, but it seems strange that it's not considered harmful to the aggressed pet's owner.

 

[Dexter_Lexia]

Should be corrected now, let me know!

 

[Hjornskar]

Just tested the same scenario again and it's still not behaving how one would expect. The opposite actually.

I tell my pet to attack a second player's pet. The second player and pet flag criminal for being the recipients of the aggressive action.

If I tell my pet to attack the second player, that works as expected -- my pet and I flag criminal. If I directly attack the second player's pet, I flag criminal in that scenario as well. So the issue I'm seeing is with ordering a pet to attack another pet.

 

[Dexter_Lexia]

Ok, so I got the logic backwards. Thanks!

 

[Dexter_Lexia]

Flipped the logic around. I tested it myself, and seemed to work good.

 

[Hjornskar]

Tested it again as well. Working as intended with regard to players and pets.

One other odd behavior, that I think ties in with this, is attacking blue NPCs in town with pets, such as a SeekerOfAdventure. I tell my pet to attack the SeekerOfAdventure and then he turns grey to me, allowing me to attack him in town without consequence.

This behavior is different than ordering a pet to attack an EscortableSeekerOfAdventure. In that case, everyone stays blue, but the pet and NPC fight.

One is a BaseEscortable and the other is a BaseEscort. The BaseEscort has InitialInnocent set to true, which likely explains the difference in outcomes when attacking them.