control slots bonuses not being applied properly

[Finaltwist]

greetings all, im trying to allow for controlslots to be determined by intelligence, herding skill and taming/lore/vet.
however, I'm not seeing the added skill bonuses being given. the following isn't being applied:



I've attached the file here for those who want to see it, its for RUNUO
I thought i got everything right... but its not being applied.

any help would be appreciated!

 

[zerodowned]

did you follow these instructions?

// Open PlayerMobile.cs and find, in the ValidateEquipment_Sandbox method, the following line:
//
// Mobile from = this;
//
// Under that line, add the line bellow:
//
// MaxFollowersIntelValued.Evaluate(from);


here

 

[Finaltwist]

yep i did...

 

[zerodowned]

ok just making sure. i'll do some testing

 

[Finaltwist]

thats why im confused... it must be on how the skills are called?
like perhaps the .Vlaue is 1000 not 100.0?

Post automatically merged: May 28, 2020

basically, initial controlslots and determined by intelligence
then a bonus for herding skill is applied
then a bonus for taming/vet/lore is applied

 

[zerodowned]

I see, it's not freshing. log out and back in and look at it.
which makes sense cause it's not meant to change after it's initially set

what you'll need to do is go to Server/Mobile.cs line 2445
here: https://github.com/ServUO/ServUO/blob/master/Server/Mobile.cs#L2445

and add
InvalidateProperties();

like so

[CommandProperty(AccessLevel.GameMaster)]
        public int FollowersMax
        {
            get { return m_FollowersMax; }
            set
            {
                if (m_FollowersMax != value)
                {
                    m_FollowersMax = value;

                    Delta(MobileDelta.Followers);
                }
               
                InvalidateProperties();
            }
        }

and don't forget to recompile the core after that

 

[Finaltwist]

okay sounds good! thanks for the help - i did restart my server and didn't see the change in my character... but i'll test more. will post if no change

 

[zerodowned]

try doing [setallskills 0 then logout and back in and look at your followers
then do [setallskills 200 then logout and back in

you should see a difference then

 

[Finaltwist]

works!! I think there was an incorrect reference in playermobile (maxfollowersintelbased instead of maxfollowersintelvalued)