Looking for items around, we randomly pick one

[Chucl]

ServUO Version

Publish Unknown

Ultima Expansion

None

Hello so i have this method:

What it does:
it looks in a range of 300 for Corpses then attach an XmlValue attachment to ALL of them


What i would like it to do;
Look in a range of 300 for Corpses then attach the XmlValue attachment to ONE corpse randomly, not all of them

Point3D location2 = this.Location;
      
                       Map map = this.Map;
                    List<Item> itemsFound = new List<Item>();
              
                    foreach (Item item in this.Map.GetItemsInRange(location2, 300))
                    {
                        if (item is Corpse)
                            itemsFound.Add(item);
                    }
              
                    for (int j = itemsFound.Count - 1; j >= 0; --j)
                    {
                          XmlAttach.AttachTo(itemsFound[j], new XmlValue("test",100));
                         }
                    }

 

[Juzzver]

int corpsesCount = itemsFound.Count;

if(corpsesCount > 0)
{
    Item corpse = itemsFound[Utility.Random(corpsesCount)];
    XmlAttach.AttachTo(corpse, new XmlValue("test",100));    
}

 

[Chucl]

Thank you so much, works perfect, nice!

 

[Chucl]

Hello again i tried your method and it works, now im trying to make a Random Xmlspawner respawn, it throws an error

   List<Item> ToShow = new List<Item>();
 
            foreach (Item item in World.Items.Values)
            {
                if (item != null && item is XmlSpawner)
                  {
               
                     ToShow.Add(item);
                    }                                              
                                                                   
            }


             foreach (Item i in ToShow)
            {
                  int corpsesCount = ToShow.Count;
 
                    if(corpsesCount > 0)
                       {
                         
               Item xml_item2 = ToShow[Utility.Random(corpsesCount - 1)];
     
                        xml_item2.Respawn();

                       }
           
            }

CS1061: Line 1084: 'Server.Item' does not contain a definition for 'Respawn' and no extension method 'Respawn' accep
ting a first argument of type 'Server.Item' could be found (are you missing a using directive or an assembly reference?)

Since it was giving me an error i wanted to test the method so i changed:

xml_item2.Respawn(); to xml_item2.ItemID = 7800

And it changes the itemid of 3 or 4 xmlspawner to 7800 instead of randomly just one, why is that?

 

[Juzzver]

You need to convert the type before use its methods. Change the:

Item xml_item2 = ToShow[Utility.Random(corpsesCount - 1)];

to

XmlSpawner xml_item2 = ToShow[Utility.Random(corpsesCount - 1)] as XmlSpawner;

Or just create the list of List<XmlSpawner> instead of List<Item>

 

[Chucl]

You need to convert the type before use its methods. Change the:

Item xml_item2 = ToShow[Utility.Random(corpsesCount - 1)];

to

XmlSpawner xml_item2 = ToShow[Utility.Random(corpsesCount - 1)] as XmlSpawner;

Or just create the list of List<XmlSpawner> instead of List<Item>

Thanks that works, but yeah it picks 4 spawners (2 of them twice), instead of just one:

 

[Juzzver]

You don't need second "foreach" for one random value.
Just use next:

                    if(ToShow.Count > 0)
                       {
                      XmlSpawner xml_item2 = ToShow[Utility.Random(ToShow.Count - 1)] as XmlSpawner;
  
                        xml_item2.Respawn();
                       }

 

[Chucl]

You don't need second "foreach" for one random value.
Just use next:

                    if(ToShow.Count > 0)
                       {
                      XmlSpawner xml_item2 = ToShow[Utility.Random(ToShow.Count - 1)] as XmlSpawner;
 
                        xml_item2.Respawn();
                       }

that was the issue yes, thank you so much