Region check is this the correct way?

[sahisahi]

public override bool CheckCast( )
        {
       
                     if (Caster != null && Caster.Player && Caster.Region != null && Caster.Region.IsPartOf( "Felucca" ) )
            return false;
                if (Caster != null && Caster.Player && Caster.Region != null && Caster.Region.IsPartOf( "Tokuno" ) )
            return false;
                 if (Caster != null && Caster.Player && Caster.Region != null && Caster.Region.IsPartOf( "Trammel" ) )
            return false;
             if (Caster != null && Caster.Player && Caster.Region != null && Caster.Region.IsPartOf( "Ilshenar" ) )
            return false;

Got this inside some custom spell, doesnt seem to work thought, thanks

 

[Po0ka]

This could be compacted a bit more:

if ( Caster == null || !Caster.Player || Caster.Region == null )
    return false;

if ( Caster.Region.IsPartOf( "Felucca" ) || Caster.Region.IsPartOf( "Trammel" ) || Caster.Region.IsPartOf( "Ilshenar" ) || Caster.Region.IsPartOf( "Tokuno" ) )
    return false;

Also tell us what it does and what it should do, just that doesn't tell us much.
Furthermore, why are you using region instead of map? Is it because of the tokuno area in malas or such?

 

[sahisahi]

Thanks.

I have a custom region i only want player be able to use that spell inside that region .

I tried this:

  if (Caster.Region.Name != "Myregionname")
    {
        Caster.SendAsciiMessage("You cannot cast that spell here");
        return false;
    }

And it doesnt work (For some reason i have exactly the same code on a different spell and it works)

So i tried to restrict that spell to Malas only, i dont know the spell is a huge mess, if i post it your eyes will bleed.

 

[Lokai]

Thanks.

I have a custom region i only want player be able to use that spell inside that region .

I tried this:

  if (Caster.Region.Name != "Myregionname")
    {
        Caster.SendAsciiMessage("You cannot cast that spell here");
        return false;
    }

And it doesnt work (For some reason i have exactly the same code on a different spell and it works)

So i tried to restrict that spell to Malas only, i dont know the spell is a huge mess, if i post it your eyes will bleed.

Post it as an attachment, that way those that are sensitive to eye-bleeding can read your post without needing to avert their eyes.

 

[sahisahi]

Heres the spell

 

[Lokai]

Heres the spell

Thanks.

OK, next, can I see your custom Regions file? (I mean the .cs file where you have them defined, not the XML file.)

 

[sahisahi]

Thanks.

OK, next, can I see your custom Regions file? (I mean the .cs file where you have them defined, not the XML file.)

I use custom regions in a box

 

[Lokai]

I use custom regions in a box

OK, then try this:

 

[sahisahi]

Weird, tried to cast it outside a region ''Ar'' . Also inside of it, no difference

 else
            {
                Caster.SendMessage(Caster.Region.Name);   // If the previous code is not working, this should tell you why....
            }

That part is not telling me the region name im in.

 

[Lokai]

Try changing it to this:

Caster.SendMessage("You are unable to cast in this region: {0} <- There should be a region name there.", Caster.Region.Name);

 

[sahisahi]

Ok im going to try that

Nothing its like is not reaching that part

 

[Po0ka]

Oh, so you want the spell to only be available in the specified regions?
Then do:

if ( !Caster.Region.IsPartOf( "Felucca" ) && !Caster.Region.IsPartOf( "Trammel" ) && !Caster.Region.IsPartOf( "Ilshenar" ) && !Caster.Region.IsPartOf( "Tokuno" ) )
    return false;

 

[sahisahi]

Oh, so you want the spell to only be available in the specified regions?
Then do:

if ( !Caster.Region.IsPartOf( "Felucca" ) && !Caster.Region.IsPartOf( "Trammel" ) && !Caster.Region.IsPartOf( "Ilshenar" ) && !Caster.Region.IsPartOf( "Tokuno" ) )
    return false;

For some reason it doesnt work, i tried

if ( !Caster.Region.IsPartOf( "Malas" ) )
Caster.SendAsciiMessage("You cannot cast that spell here");
return false;

Cant cast inside malas or even outside, it get the same ''You cannot cast that spell here'' message everywhere :S.

Im thinking of giving an attachment to players so they can cast spells then remove it after event is done. At least it works that way.

 

[Lokai]

What is "sorakabooka"?

 

[sahisahi]

Hehe just an attachment, thats the attachment i added to fix the issue.

sorakabooka is just a random name

 

[Lokai]

Hehe just an attachment, thats the attachment i added to fix the issue.

sorakabooka is just a random name

Try this one and let me know EXACTLY what messages get sent to the Caster when you use it.

 

[sahisahi]

Try this one and let me know EXACTLY what messages get sent to the Caster when you use it.

Ok, going to try right now

Good way to debug :O

Im inside a region called Sr

 if (Caster.Region.Name != "Sr"   //means if the region is not called Sr we dont allow right?
{
                Caster.SendAsciiMessage("No puedes utilizar esa habilidad aqui eso aqui!"); //WHY THIS CODE IS NOT WORKING?
                return false; //WHY THIS CODE IS NOT WORKING?
            }

In felucca Test 3 still suceed, how come?

 

[Voxpire]

Regions are layered, so you can actually be in multiple regions at the same time.

Typically Mobile.Region is never null because the entire map has an unnamed "Default Region", which will be why no region name is showing in the output tests. When you're in the wilderness, you're typically in the Map's top-level (default) region. The Region.IsDefault property returns true for the map's default region.

Region.IsPartOf( ) checks the hierarchy of the target's Region, so it will check the names of every parent region.

if ( Caster.Region.IsPartOf( "Custom Region Name" ) )
{
    // current region, or one of its parents, was found.
}