ServUO Code Cleanup / Project cleaning

[Dan]

https://github.com/ServUO/ServUO/pull/3006

So following along with what @argalep started should we also look at the random XMLSpawner2 systems? Like the games and stuff? There are some random mentions of using Server.Engines.XMLSpawner2; in certain scripts that seem to not need to be there.

I honestly do like the xmlspawner for world spawning and [xmlfind is a must. Are a lot of the games in there needed though? Can we remove some of the random references to XMLSpawner2. I sent a PR for one of them I found in CharacterCreation.cs
https://github.com/ServUO/ServUO/pull/3007

 

[PyrO]

There are extensions for Visual Studio that just remove unused using statements when you save.

But the thing is it doesnt hurt to have them in either. The compilers handles it in the end

 

[Milva]

Hmm I think @Dexter_Lexia and maybe @dmurphy and @Voxpire should weigh in on this also?

 

[Argalep]

I do not think you need the extra functions in xmlspawner.

 

[Dexter_Lexia]

What about Omni AI?

 

[Voxpire]

I don't use XmlSpawner for anything, ever, so my opinion is bias towards removing it. However, I do understand that it is an important and helpful tool for a lot of shard owners and developers.

There is definitely a lot of "fluff" that comes with it that isn't necessary, but then again, the same could be said for my Vita-Nex: Core project. It is entirely subjective.

I say just bundle the entire thing as always, and let the end user determine which "fluff" they want to remove and/or keep.